-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New webxdc api #4380
New webxdc api #4380
Conversation
Needs next core release |
Core 1.151.3 is published |
- pass whole message to internalOpenWebxdc to reduce db calls - add href to DcOpenWebxdcParameters
0aeacaf
to
5e47c0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a bunch of questions. Hate to be that guy, but this MR affects security-critical code.
Overall I think we need more comments. Clearly document function contracts and parameters, are they sanitized or not. If not, how they need to be sanitized. The assumptions, etc.
No worries. I appreciate critical feedback! :-) |
replace deprecated substr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about the "internetAccess" warning. Please check it out and resolve as you wish.
Otherwise it's good, though ideally I'd like more comments, and get rid of exposeInMainWorld
for setLocationUrl
. But this can be done later.
IMO This is ready to be merged. (but FYI a CHANGELOG entry is missing)
resolves (partly) to #4366
Main changes: