fullscreen media view: improve drag behaviour and remove visible scrollbars #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves #4368 (for now, I know that it could be even better, but this commit makes fixes the big problem of inconsistent dragging behaviour)
WofWca
approved these changes
Dec 4, 2024
nicodh
deleted the
simon/improve-dragging-and-fix-fullscreenmedia-view-scrollbar-problem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4368 (I know we could do even better, but this invisible drag area where the navbar would be already fixes the bug in my eyes)
The scrollbar problem: (those scrollbars are just a visual bug, they don't really do anything as far as I understood it)
The drag area: