Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: mark bots as such in UI #4405

Merged
merged 2 commits into from
Dec 12, 2024
Merged

improvement: mark bots as such in UI #4405

merged 2 commits into from
Dec 12, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Dec 11, 2024

  • refactor: simplify navbar-chat-subtitle
  • improvement: mark bots as such in UI

Closes #4332.

Thanks @r10s for the detailed instructions in #4332!

Tested with a bot. Works.

@WofWca WofWca force-pushed the wofwca/mark-bots-as-such branch from e4fd5dd to c2c72df Compare December 11, 2024 21:28
@WofWca WofWca marked this pull request as ready for review December 11, 2024 21:28
@WofWca WofWca changed the title wofwca/mark bots as such improvement: mark bots as such in UI Dec 11, 2024
@@ -360,7 +365,7 @@ function ChatHeading({ chat }: { chat: T.FullChat }) {
</div>
</div>
{subtitle && subtitle.length && (
<div className='navbar-chat-subtitle'>{chatSubtitle(chat)}</div>
<div className='navbar-chat-subtitle'>{subtitle}</div>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this change is unrelated.

Copy link
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by testing & reading

@r10s
Copy link
Member

r10s commented Dec 11, 2024

thanks a lot, @WofWca

@WofWca WofWca merged commit 89bdf41 into main Dec 12, 2024
11 checks passed
@WofWca WofWca deleted the wofwca/mark-bots-as-such branch December 12, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark bots as such
3 participants