fix: a11y: arrow-key navigation stopping working after ~10 keypresses #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicodh
reviewed
Jan 10, 2025
|
I just edited the description:
|
nicodh
approved these changes
Jan 12, 2025
...upon re-render. See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level.
...upon re-render. See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level.
...upon re-render. See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level.
...upon re-render. See bvaughn/react-window#420 (comment). This commit ensures that the renderer function is defined at the top-level, and not inline.
See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level. This does not appear to have functional impact as of now, but will come in handy after #4376.
See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level. This does not appear to have functional impact as of now, but will come in handy after #4376.
WofWca
force-pushed
the
wofwca/fix-roving-tabindex-react-window
branch
from
9db5c71 to
0230587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing commit-by-commit should be a bit easier. But basically what this does is it un-inlines the renderer functions, addressing this issue: bvaughn/react-window#420 (comment).
You can check this behavior by arrow-key navigating the contact list in "new chat", as long as your contact list is at least ~30 items long. When new items get loaded (with 'react-infinite-loader'), the parent component re-renders, and all items' DOM get re-created, losing focus.
I am not 100% sure whether we should squash the commits. They're all quite similar, but it might not be easy to see separate logical changes when squashed.