Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental content protection option #4475

Merged

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Jan 11, 2025

it is off by default and and an experimental setting and hidden on linux because this api is macOS and windows only

closes #4347

On macOS the window is hidden from screenshots but not from screen recording.

The change should apply to all windows (main app, help, html email view, webxdc)

@Simon-Laux Simon-Laux changed the title add experiemental content protection option add experimental content protection option Jan 11, 2025
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this does not apply to webxdc windows? I mean the webxdc.ts file is unchanged.

Copy link
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows10 - complete app including webxdc apps are excluded from screenshots when the feature is enabled!!

Couldn't test screen recoring though, due to missing hardware support (VritualBox)

Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. Tested on Linux, where this feature is not supported, and it works as usual: the setting is not displayed in the UI, and the windows.setContentProtection(enabled) is executed, but doesn't throw.

@Simon-Laux Simon-Laux merged commit d990b37 into main Jan 15, 2025
3 of 8 checks passed
@Simon-Laux Simon-Laux deleted the simon/i4347-add-content-protection-experiemental-option branch January 15, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Electron setContentProtection API on Windows and macOS
4 participants