-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add experimental content protection option #4475
add experimental content protection option #4475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this does not apply to webxdc windows? I mean the webxdc.ts file is unchanged.
it is off by default and an experimental setting closes #4347
1a3e9aa
to
8bd3026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Windows10 - complete app including webxdc apps are excluded from screenshots when the feature is enabled!!
Couldn't test screen recoring though, due to missing hardware support (VritualBox)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright. Tested on Linux, where this feature is not supported, and it works as usual: the setting is not displayed in the UI, and the windows.setContentProtection(enabled)
is executed, but doesn't throw.
Co-authored-by: WofWca <[email protected]>
it is off by default and and an experimental setting and hidden on linux because this api is macOS and windows only
closes #4347
On macOS the window is hidden from screenshots but not from screen recording.
The change should apply to all windows (main app, help, html email view, webxdc)