Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tauri: copy to clipboard #4528

Merged
merged 5 commits into from
Feb 6, 2025
Merged

tauri: copy to clipboard #4528

merged 5 commits into from
Feb 6, 2025

Conversation

Septias
Copy link
Contributor

@Septias Septias commented Jan 21, 2025

Add the capability to copy images to the clipboard

@Simon-Laux
Copy link
Member

Simon-Laux commented Jan 23, 2025

could you rebase it to merge into #4533?
so that the rust method can be inside of clipboard.rs and you can use the Error type in that file instead of doing the string conversion. (see https://tauri.app/develop/calling-rust/#error-handling)

@Septias Septias changed the base branch from main to qr_text_result_dialog_copy January 29, 2025 12:20
@Septias Septias changed the base branch from qr_text_result_dialog_copy to simon/t2 January 29, 2025 12:25
@Septias Septias marked this pull request as ready for review January 29, 2025 12:27
@Septias Septias requested a review from Simon-Laux January 29, 2025 12:27
@Septias
Copy link
Contributor Author

Septias commented Jan 29, 2025

I changed the base to target your commit so you get a nicer diff on the web view, we can first merge it to your branch actually or wait until it is merged or merge it into main afterward.

@Septias
Copy link
Contributor Author

Septias commented Jan 29, 2025

For testing, I have the image visible in my clipboard manager but can not paste it really. Might be Nixos though.

@Simon-Laux Simon-Laux added this to the Tauri Project milestone Feb 5, 2025
@Simon-Laux Simon-Laux merged commit 46cb86e into simon/t2 Feb 6, 2025
10 of 17 checks passed
@Simon-Laux Simon-Laux deleted the sk/image_pasting branch February 6, 2025 20:51
Simon-Laux pushed a commit that referenced this pull request Feb 6, 2025
* add nix to gitignore

* add copy to clipboard functionality

* remove flake files

* rm .envrc

* move to clipboard
Simon-Laux pushed a commit that referenced this pull request Feb 9, 2025
* add nix to gitignore

* add copy to clipboard functionality

* remove flake files

* rm .envrc

* move to clipboard
Simon-Laux added a commit that referenced this pull request Feb 10, 2025
…also fix pasting of (non-image) files into composer (#4533)

* tauri: implement `runtime.readClipboardImage`

* fix pasting of files by using browser apis instead of `runtime.writeClipboardToTempFile`

* remove now unused `runtime.writeClipboardToTempFile`

* runtime: writeTempFileFromBase64 and writeTempFile

* fix some lints

* fix: translation fallback to 'en' not to 'en-US' (en-US isnt valid)

* added changelog message

* SetLocale functionality

* Moved and organized files of tauri translation system

* Implemented Error handling for i18n in extra file 'errors.rs'

* fix fmt of this pr

* fix lint of underlying pr

* fix fmt

* tauri: copy to clipboard (#4528)

* add nix to gitignore

* add copy to clipboard functionality

* remove flake files

* rm .envrc

* move to clipboard

* fix clippy lint

* remove tmp files

* remove debug print

* side effects for desktop settings & first part of content protection

* fix LocaleData.locale bug where it showed name instead of language code

* cargo fmt

* tauri: help window support for localisation

* apply suggestions from code review

* switch to nightly rustfmt to enable group_imports = "StdExternalCrateLocal"

* go back to stable formatiing because group imports feature can change meaning of comments if not careful.

* apply code review suggestions

* cargo fmt

* add changelog entry for tauri changes

* fix cargo.lock after rebase

---------

Co-authored-by: nojisan <[email protected]>
Co-authored-by: Sebastian Klähn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants