fix: chat scrolling up on quoting sometimes #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-on-draft-quote
branch
from
0316534 to
22d1de9
Compare
Closes #3763 (again). See #3763 (comment). Previous supposed fix: #4119. Apparently the bug came back after the recent React upgrade.
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-on-draft-quote
branch
from
22d1de9 to
03f62e5
Compare
WofWca
added a commit
that referenced
this pull request
Jan 25, 2025
This cause the message list to be empty when the chat gets opened, and not update on some events. Reproduction steps are roughly as follows: 1. Create two accounts 2. On Alice, send ~20 messages to Bob. 3. Switch to Bob's account and open the chat with Alice. Do not scroll to bottom. 4. Switch to Alice account and send another message to Bob. 5. Switch to Bob's account and open the chat with Alice. You will see the `Failed to load message Msg#0 for account` error in the console and the chat will be empty. The bug was introduced in 7a968b6 (#4529). The added `messageId > C.DC_MSG_ID_LAST_SPECIAL` in the first `if` is purely for consistency and performance. It's the second one that matters.
WofWca
added a commit
that referenced
this pull request
Jan 25, 2025
This cause the message list to be empty when the chat gets opened, and not update on some events. Reproduction steps are roughly as follows: 1. Create two accounts 2. On Alice, send ~20 messages to Bob. 3. Switch to Bob's account and open the chat with Alice. Do not scroll to bottom. 4. Switch to Alice account and send another message to Bob. 5. Switch to Bob's account and open the chat with Alice. You will see the `Failed to load message Msg#0 for account` error in the console and the chat will be empty. The bug was introduced in 7a968b6 (#4529). The added `messageId > C.DC_MSG_ID_LAST_SPECIAL` in the first `if` is purely for consistency and performance. It's the second one that matters.
WofWca
added a commit
that referenced
this pull request
Jan 25, 2025
This sometimes causes the message list to be empty when the chat gets opened, and not update on some events. Reproduction steps are roughly as follows: 1. Create two accounts 2. On Alice, send ~20 messages to Bob. 3. Switch to Bob's account and open the chat with Alice. Do not scroll to bottom. 4. Switch to Alice account and send another message to Bob. 5. Switch to Bob's account and open the chat with Alice. You will see the `Failed to load message Msg#0 for account` error in the console and the chat will be empty. The bug was introduced in 7a968b6 (#4529). The added `messageId > C.DC_MSG_ID_LAST_SPECIAL` in the first `if` is purely for consistency and performance. It's the second one that matters.
WofWca
added a commit
that referenced
this pull request
Jan 25, 2025
This sometimes causes the message list to be empty when the chat gets opened, and not update on some events. Reproduction steps are roughly as follows: 1. Create two accounts 2. On Alice, send ~20 messages to Bob. 3. Switch to Bob's account and open the chat with Alice. Do not scroll to bottom. 4. Switch to Alice account and send another message to Bob. 5. Switch to Bob's account and open the chat with Alice. You will see the `Failed to load message Msg#0 for account` error in the console and the chat will be empty. The bug was introduced in 7a968b6 (#4529). The added `messageId > C.DC_MSG_ID_LAST_SPECIAL` in the first `if` is purely for consistency and performance. It's the second one that matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3763 (again).
See #3763 (comment).
Previous supposed fix: #4119.
Apparently the bug came back after the recent React upgrade, which was introduced in 1.51.0, so the bug is a regression.
I was unable to reproduce the bug on the Windows preview build from this MR.