feat: display past chat members #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
requested changes
Jan 22, 2025
link2xt
force-pushed
the
link2xt/past-members
branch
from
29da587 to
b44eed1
Compare
link2xt
force-pushed
the
link2xt/past-members
branch
from
2639260 to
24fa0ee
Compare
link2xt
force-pushed
the
link2xt/past-members
branch
from
24fa0ee to
142917a
Compare
WofWca
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Works nicely, after a bit of testing!
When removing members, they show up immediately in the "past members" section. Roving tabindex also works as intended. Same for clicking on members.
I left a small suggestion, but it's not important, feel free to ignore it.
link2xt
force-pushed
the
link2xt/past-members
branch
from
dd8023d to
f4f8cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the core now has a new group consistency algorithm, the list of past members who left the group in the last 90 days is sent around in the (encrypted) header. Displaying it makes users aware that this happens and past members are known even to the new members. Besides "security" aspect, the feature is just occasionally useful to check "have I removed the bot from the group already, or just cannot find it in the huge member list?".
For use together with chatmail/core#6442