fix: scroll selected account into view on startup #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-account-scrollIntoView
branch
from
9917943 to
3cb2f48
Compare
nicodh
reviewed
Jan 24, 2025
|
Is it on "clean" startup, i.e. after complete quitting? |
|
If yes, could you also try the preview build? IIRC I also had trouble with this on the dev setup, but I forgot the reason. (works for me on the Windows preview BTW) |
nicodh
approved these changes
Jan 28, 2025
The feature was introduced in 46d9811 (#4137), but then broken apparently in d13a36c (#4280). As a side-effect, this will also show "placeholder" acount list items while the accounts are loading. And it makes the account list items interactive while they're loading, i.e. you can select one or activate the context menu. Another thing this fixes is roving tabindex while the accounts are loading, but isn't really important.
WofWca
force-pushed
the
wofwca/fix-account-scrollIntoView
branch
from
3cb2f48 to
9d86cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature was introduced in 46d9811,
but then broken apparently in d13a36c.
As a side-effect, this will also show "placeholder" acount list items
while the accounts are loading.
And it makes the account list items interactive
while they're loading, i.e. you can select one
or activate the context menu.
Another thing this fixes is roving tabindex
while the accounts are loading, but isn't really important.