improvement: focus message when jumping to it #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where appropriate. Most notably: - When jumping to message from quote click - When jump to webxdc app from "Show app in chat" context menu item - After "Show in chat" from the gallery Let's add `focus: true` only to the most basic cases for now, and later consider expanding this, and perhaps even adding some logic / settings as to whether to focus the message.
WofWca
force-pushed
the
wofwca/a11y-focus-on-jumpToMessage
branch
from
5a567e3 to
b265c9e
Compare
nicodh
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where appropriate. Most notably:
Let's add
focus: trueonly to the most basic cases for now,and later consider expanding this, and perhaps even adding
some logic / settings as to whether to focus the message.