refactor: fix message list potentially being empty #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-message-list-empty
branch
from
1f23de5 to
3e412ad
Compare
WofWca
force-pushed
the
wofwca/fix-message-list-empty
branch
from
3e412ad to
cbc5444
Compare
WofWca
force-pushed
the
wofwca/fix-message-list-empty
branch
from
cbc5444 to
ec81292
Compare
WofWca
changed the title
store.subscribe)
WofWca
force-pushed
the
wofwca/fix-message-list-empty
branch
from
ec81292 to
4da4970
Compare
nicodh
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Looks good to me and seems to make sense, although I would prefery to get this approved by @Simon-Laux since I'm not too familiar with the message store behaviour in detail
Simon-Laux
approved these changes
Jan 29, 2025
...sometimes. And maybe sometimes showing messages from previous chat. I have not been able to confirm whether this fixes an actual bug. But at least in my understanding this fixes a semantic error. The presence of the error is obvious if you make `store.effect.loadChat()` synchronous. So, what could be happening is that `loadChat` finishes _before_ we subscribe to the new store instance, and thus the state never gets updated, at least not until the next store update, which could be e.g. `fetchMoreMessagesTop`.
Currently it appears that `useStore` is not really used with an argument that can change, so this is just a refactor and not a fix. See previous commit (the messagelist.ts change, `setState(store.getState())`).
WofWca
force-pushed
the
wofwca/fix-message-list-empty
branch
from
4da4970 to
bde1567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...sometimes.
And maybe sometimes showing messages from previous chat.
I have not been able to confirm whether this fixes
an actual bug.
But at least in my understanding this fixes a semantic error.
The presence of the error is obvious if you make
store.effect.loadChat()synchronous.So, what could be happening is that
loadChatfinishes beforewe subscribe to the new store instance,
and thus the state never gets updated,
at least not until the next store update, which could be e.g.
fetchMoreMessagesTop.The second commit also appears to be just a refactor.