perf: open chats faster (`loadChat()`) #4561

WofWca · 2025-01-25T16:38:56Z

No description provided.

Simon-Laux · 2025-01-27T17:35:27Z

packages/frontend/src/stores/messagelist.ts

          })
+
+          // TODO why do we only do this when `firstUnreadMsgId !== null`?


good question, maybe it was meant as an optimisation attempt. I think we can try to change it.

Simon-Laux

Code LGTM, I didn't test it

`BasicChat.id` is never null.

...when chat has unread messages. FYI The `setTimeout` part was introduced in fe035bd (#2750).

WofWca had a problem deploying to test January 25, 2025 16:39 — with GitHub Actions Failure

WofWca force-pushed the wofwca/perf-loadChat branch from 9951db2 to 3d6ff93 Compare January 25, 2025 16:44

WofWca had a problem deploying to test January 25, 2025 16:44 — with GitHub Actions Failure

WofWca marked this pull request as ready for review January 25, 2025 16:59

WofWca mentioned this pull request Jan 25, 2025

fix: jumpToMessage flashing the bottom of new chat #4562

Merged

Simon-Laux reviewed Jan 27, 2025

View reviewed changes

Simon-Laux approved these changes Jan 27, 2025

View reviewed changes

WofWca force-pushed the wofwca/perf-loadChat branch from 3d6ff93 to ecaf4a8 Compare January 28, 2025 12:40

WofWca added 3 commits January 28, 2025 16:41

refactor: remove dead code

1d9d1bc

`BasicChat.id` is never null.

perf: improve loadChat speed

5972183

...when chat has unread messages. FYI The `setTimeout` part was introduced in fe035bd (#2750).

perf: loadChat()s even faster

bb6c715

WofWca force-pushed the wofwca/perf-loadChat branch from ecaf4a8 to bb6c715 Compare January 28, 2025 12:43

WofWca had a problem deploying to test January 28, 2025 12:43 — with GitHub Actions Failure

WofWca merged commit e147f57 into main Jan 28, 2025
7 of 11 checks passed

WofWca deleted the wofwca/perf-loadChat branch January 28, 2025 12:44

Provide feedback

		})

		// TODO why do we only do this when `firstUnreadMsgId !== null`?