chore: upgrade emoji-mart to fix memory leak #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-emojimart-memory-leak
branch
from
f495eed to
eb32a99
Compare
WofWca
force-pushed
the
wofwca/fix-emojimart-memory-leak
branch
from
eb32a99 to
c9e808a
Compare
~1 MB per open-close cycle. Apparently it's missive/emoji-mart#868. Co-authored-by: Simon Laux <[email protected]>
WofWca
force-pushed
the
wofwca/fix-emojimart-memory-leak
branch
from
c9e808a to
7cd9eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~1 MB per open-close cycle.
Apparently it's this issue: missive/emoji-mart#868
I have confirmed that this fixes the memory leak. This is after ~50 clicks. Before:
After: