store last account id in core by using selectAccount (which stores it in account manager/accounts.toml) #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in account manager/accounts.toml) This fixes that the update device message is left unread in the wrong account (because that used the value from core already and it wasn't updated by desktop so it was wrong).
link2xt
approved these changes
Jan 27, 2025
| /** path to last used/selected Account */ | ||
| /** path to last used/selected Account | ||
| * | ||
| * @deprecated in favor of storing selected account over core account manager in accounts.toml |
There was a problem hiding this comment.
In the core we usually add the date when this was deprecated, e.g. 2025-01-27, so this can be completely removed at some point.
WofWca
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that the update device message is left unread in the wrong account (because that used the value from core already and it wasn't updated by desktop so it was wrong).
closes #4474