fix: "jump down" button incorrect badge count #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-jump-down-counter
branch
from
f299816 to
51c978e
Compare
...it show the value from another chat. This can happen if the chat has been switched, but no relevant events occurred after the chat has been switched. Closes #3978.
`MsgRead` only applied to outgoing messages, so it doesn't affect the value returned from `BackendRemote.rpc.getFreshMsgCnt()`.
WofWca
force-pushed
the
wofwca/fix-jump-down-counter
branch
from
51c978e to
6c1f9ef
Compare
nicodh
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...it show the value from another chat.
This can happen if the chat has been switched, but no relevant
events occurred after the chat has been switched.
Closes #3978.
The second commit should not affect behavior, unless the core docs are wrong.
I only tested that the reproduction steps from #3978 (comment) are no longer reproducible. I did not test too deeply.