Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chat list & chat view showing different chats #4615

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Feb 8, 2025

Reproduction steps:

  1. Select a chat with a lot of members, e.g. 100
    (use Ctrl + Tab for speed).
  2. Immediately select another chat with few members,
    e.g. 1 on 1 chat (click it in the chat list for speed).
2025-02-10-wbAMus2RST.mp4

You'll notice that the chat list shows the chat from step 2,
but the messages list and the header shows the chat from step 1.

This issue belongs to the class of issues described in
#4501.

Reproduction steps:
1. Select a chat with a lot of members, e.g. 100
  (use Ctrl + Tab for speed).
2. Immediately select another chat with few members,
  e.g. 1 on 1 chat (click it in the chat list for speed).

You'll notice that the chat list shows the chat from step 2,
but the messages list and the header shows the chat from step 1.

This issue belongs to the class of issues described in
#4501.
Copy link
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't really test, since I could not reproduce the race condition. At least I experienced no errors when testing.

But code looks good to me.

@WofWca
Copy link
Collaborator Author

WofWca commented Feb 10, 2025

I uploaded a video recording of the bug.

@WofWca WofWca merged commit 166ee8a into main Feb 10, 2025
12 checks passed
@WofWca WofWca deleted the wofwca/fix-selectChat-race branch February 10, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants