fix: some resource leaks #4634
Merged
fix: some resource leaks #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was introduced in 0b933ac. `Array.every()` stops iterating the array if the closure evaluates to a falsy value. This results in only the first event listener getting cleaned up.
As in the previous commit, `Array.every()` stops iterating through the array if the closure return value is falsy.
WofWca
force-pushed
the
wofwca/fix-FullscreenMedia-resource-leak
branch
from
986ab81 to
e783ebd
Compare
Simon-Laux
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FullscreenMedia