-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix source code links in app picker #4637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it work.
Though I wonder if we want a punycode warning as in here?:
deltachat-desktop/packages/frontend/src/components/message/Link.tsx
Lines 170 to 200 in f9634a7
export const Link = ({ | |
destination, | |
tabIndex, | |
}: { | |
destination: LinkDestination | |
tabIndex: -1 | 0 | |
}) => { | |
const { openDialog } = useDialog() | |
const openLinkSafely = useOpenLinkSafely() | |
const accountId = selectedAccountId() | |
const { target, punycode } = destination | |
const processQr = useProcessQr() | |
const asciiUrl = punycode ? punycode.punycode_encoded_url : target | |
const onClick = (ev: any) => { | |
ev.preventDefault() | |
ev.stopPropagation() | |
if (isInviteLink(target)) { | |
processQr(accountId, target) | |
return | |
} | |
if (punycode) { | |
openDialog(PunycodeUrlConfirmationDialog, { | |
originalHostname: punycode.original_hostname, | |
asciiHostname: punycode.ascii_hostname, | |
asciiUrl: punycode.punycode_encoded_url, | |
}) | |
} else { | |
openLinkSafely(accountId, target) |
we can make an issue for that, good idea. maybe we should also expose a separate api in message parser lib to check links for puny code. But here is is not a blocker, because phishing here is unlikely. |
fix #4631