fix: a11y: 'tablist' role for gallery / chat view #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/a11y-tabs
branch
from
868f1e0 to
65a5510
Compare
Simon-Laux
reviewed
Feb 20, 2025
Simon-Laux
reviewed
Feb 20, 2025
Comment on lines
438
to
439
| // Yes, this is not marked as `role='tab'`. | ||
| // I'm not sure if this is alright. |
There was a problem hiding this comment.
I guess it should tell that it opens a new window with the map. but the map is an experimental feature and not accessible (just tested it with voiceover).
There was a problem hiding this comment.
I've been researching aria-haspopup="dialog". It applies to many buttons in our app, not just this one. But I am not sure yet whether it's good. I suggest to wait for the report, and see if they have concrete suggestions for this.
Simon-Laux
approved these changes
Feb 20, 2025
WofWca
force-pushed
the
wofwca/a11y-tabs
branch
from
65a5510 to
7e54f8f
Compare
if you listen to the screen-reader, it's not clear what the buttons do, and how to change the active view. This should fix it.
WofWca
force-pushed
the
wofwca/a11y-tabs
branch
from
7e54f8f to
a076b15
Compare
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you listen to the screen-reader, it's not clear
what the buttons do, and how to change the active view.
This should fix it.