open map in landscape orientation and constrain default webxdc bounds by screen workarea #4683
Conversation
… by screen workarea - open map in landscape orientation and with a bigger window - constrain size of webxdc window by available screen-workarea-space closes #3847
Simon-Laux
force-pushed
the
simon/i3847
branch
from
615d662 to
9b71eca
Compare
|
I just tested this locally but the map looks like a normal webxdc Opened by
I'm guessing this happens because I have opened the map before and it has saved it's bounds already. So this fix only has effect for people opening the map for the first time, right? |
|
@Simon-Laux I can make a PR into this branch instead. It's easier to show what I mean that way. See if you like it or not. |
yes it only affects new/fresh accounts BTW: I don't like the whole way of reusing webxdc for the map and abusing the update mechanism, which only allows one instance of the map currently. IMO we need to think about a good way to do deltachat extensions, as their own thing, separate from webxdc. Like expose a dedicated jsonrpc api with autogenerated bindings that you can easily develop extensions and don't need to invent a new RPC mechanism over sending status updates that doesn't even do error handling and has no typescript types. Also the map xdc itself still lacks features that the old map box map had. But enough ranting, for now it is what it is and we will need some time in the future where we focus on it to make it really nice. |
* Pass in default size instead of booleans * Put the comment back on why map is using a different size * Always compute the default size at the last minute + document adjust function * Adjust all bounds * Adjust size separately * Remove default
closes #3847