html email view: migrate from deprecated BrowserView to WebContentsView
#4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sView` according to this blogpost https://www.electronjs.org/blog/migrate-to-webcontentsview
Simon-Laux
force-pushed
the
simon/update-html-view-to-avoid-using-deprecated-electron-api
branch
from
30a5392 to
71da3cf
Compare
ralphtheninja
approved these changes
Feb 21, 2025
* - fix that in html email view links without schema didn't open in browser - fix clicking on the same anchor multiple timed disn't work in html email view closes #4017 * Update packages/target-electron/src/windows/html_email.ts Co-authored-by: ralphtheninja <[email protected]> --------- Co-authored-by: ralphtheninja <[email protected]>
Simon-Laux
deleted the
simon/update-html-view-to-avoid-using-deprecated-electron-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to this blogpost https://www.electronjs.org/blog/migrate-to-webcontentsview