-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searchfield for help #4691
Searchfield for help #4691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. For the translation keys I think it makes more sense to use the existing substitution pattern, you can convert it to the custom one in bin/help/help-translations.js
.
- reasons: reusability and consistency
echo | ||
echo "☝️ Compliance Warning: Add the following line to CHANGELOG.md:" | ||
echo "- Update local help ("`date "+%Y-%m-%d"`")" | ||
echo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice detail 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not work out of the box and I agree with the idea that pagefind.js
and wasm.unknown.pagefind
should not be duplicated - maybe they could be imported via import statement from start-pagefind.js
?
maybe |
Sorry - the problem was, that I didn't commit the changes needed after the update of deltachat-pages |
Concerning the redundant files: pagefind expects the wasm files to be at the same path as pagefind-ui.js & pagefind.js. What I did now is: copy the needed files to static/help/ and remove them from /static/help//pagefind/ in build process. |
bad idea, app files at runtime should be treated immutable. what you can do is making a custom uri schema for the help and match on the name to return the same file in all sub directories, similar to how |
- use new add_pagefind parameter - use common language keys - add search element on runtime
Co-authored-by: Simon Laux <[email protected]>
- add new pagefind param to script - remove existing pagefind dir completely - remove all pagefind js files
3101293
to
557ebf0
Compare
I found a solution: added a lang attribute to each help page and moved the pagefind indexing one level up, so all data goes into one pagefind directory while pagefind assigns the index per language and shows only appropriate matches |
You have an idea why? It's just a Unicode 🞫 ? |
you need to load a font that supports it |
You mean it depends if your system font supports it? Does it makes sense to look for another sign with better support? Maybe https://en.wikipedia.org/wiki/Multiplication_sign ? |
|
this PR has reverted the help to a pretty old state, i'll did an update at #4725 , not sure, if pagefine script ran correctly there, that should be double-checked |
This PR adds a search field to the help page, using pagefind which generates an index which is then used to search and disply results in the static help page.
Needs latest main of https://github.com/deltachat/deltachat-pages/