Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show "edited" in message status line #4697

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Feb 21, 2025

Closes #4694.
Depends on (hence draft):

image

image

skip-changelog because:

  • We'll probably have an entry for the core upgrade. Check if it's the case prior to merging.

@WofWca WofWca added new-core involves or requires an core update new DC feature New features in core that need adaptions in desktop labels Feb 21, 2025
@WofWca WofWca force-pushed the wofwca/edited-messages-show-mark branch from 2e2e91a to a1094b4 Compare February 21, 2025 18:03
@nicodh
Copy link
Member

nicodh commented Feb 28, 2025

Since core is updated now, this needs a rebase and can be reviewed.

For reviewing/testing: How can I set the isEdited state in database?

@WofWca WofWca force-pushed the wofwca/edited-messages-show-mark branch from a1094b4 to d1ea75c Compare February 28, 2025 08:22
@WofWca
Copy link
Collaborator Author

WofWca commented Feb 28, 2025

I haven't tested it with a real database. If you want, you can edit messages on this branch: main...wofwca/edit-messages

@WofWca
Copy link
Collaborator Author

WofWca commented Feb 28, 2025

this needs a rebase and can be reviewed.

And a translations update is still missing

@nicodh
Copy link
Member

nicodh commented Feb 28, 2025

I haven't tested it with a real database. If you want, you can edit messages on this branch: main...wofwca/edit-messages

Ok, the "flag" in the database is, to set the param to
L=1
c=1
(including a line break)

@WofWca WofWca force-pushed the wofwca/edited-messages-show-mark branch from d1ea75c to ca0d200 Compare February 28, 2025 09:49
@WofWca WofWca force-pushed the wofwca/edited-messages-show-mark branch from ca0d200 to edcbf8d Compare February 28, 2025 09:56
@WofWca WofWca marked this pull request as ready for review February 28, 2025 09:56
Copy link
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by reading & testing

@WofWca WofWca merged commit 6a294e2 into main Feb 28, 2025
12 checks passed
@WofWca WofWca deleted the wofwca/edited-messages-show-mark branch February 28, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new DC feature New features in core that need adaptions in desktop new-core involves or requires an core update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show "Edited" if message was edited
2 participants