Show dialog if backup is too new #4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #4709
|
For testing paste a string starting with DCBACKUP3 like "DCBACKUP3:fooo" in the add second device qr scanning dialog |
| await openAlertDialog({ | ||
| message: tx('multidevice_receiver_needs_update'), | ||
| }) | ||
| callback?.() |
There was a problem hiding this comment.
Is this some TypeScript magic?
There was a problem hiding this comment.
Nvm, I looked it up. I'm guessing this is checking if the callback is defined before invoking it.
There was a problem hiding this comment.
A general comment about this useProcessQR() function. It looks like it's only used in one place (PseudoListItem.tsx), which doesn't pass in a callback, so maybe we should just remove all the callback-invoking code? (I can make a PR for that so this PR isn't blocked).
There was a problem hiding this comment.
It's used multiple times and sometimes witha callback:
or
Which is for closing a dialog etc.
ralphtheninja
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4709