fix: unclosable webxdc apps (beforeunload)
#4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-unclosable-webxdc
branch
from
182beb8 to
38dbf0b
Compare
WofWca
added
webxdc
Runtime: Electron
ralphtheninja
approved these changes
Mar 3, 2025
|
Now when I close realtime editor, it asks "Close app?" but closes regardless of whether I click "Cancel" or "Close Window". |
|
Ahhh. Thanks for testing, @link2xt! I'll take care of it. |
WofWca
added a commit
that referenced
this pull request
Mar 4, 2025
The bug was introduced in e722175 (#4728). [The Editor app](https://codeberg.org/webxdc/editor), when getting closed, would always cause the "Close app?" dialog to get shown to the user, but it's not intentional, because the app would close regardless of what the user picks. See the code comments for more info.
WofWca
added a commit
that referenced
this pull request
Mar 4, 2025
The bug was introduced in e722175 (#4728). [The Editor app](https://codeberg.org/webxdc/editor), when getting closed, would always cause the "Close app?" dialog to get shown to the user, but it's not intentional, because the app would close regardless of what the user picks. See the code comments for more info.
WofWca
added a commit
that referenced
this pull request
Mar 12, 2025
The bug was introduced in e722175 (#4728). [The Editor app](https://codeberg.org/webxdc/editor), when getting closed, would always cause the "Close app?" dialog to get shown to the user, but it's not intentional, because the app would close regardless of what the user picks. See the code comments for more info.
WofWca
added a commit
that referenced
this pull request
Mar 12, 2025
The bug was introduced in e722175 (#4728). [The Editor app](https://codeberg.org/webxdc/editor), when getting closed, would always cause the "Close app?" dialog to get shown to the user, but it's not intentional, because the app would close regardless of what the user picks. See the code comments for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4726.
Here is an example of an app that uses
beforeunload:2025-03-03-3k6vhkaU0E.mp4