-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
401 Unauthorized: Temp URL invalid if path contains whitespaces #79
Comments
Got an example of an invalid url? |
Please review the PR. Also: Is this bug about file names containing spaces? It would be nice to get an example-url so we can write a test for this specific situation. |
Will let you know shortly ! |
Great. Not sure if the quoting matters or not. That's the only thing missing from your example. |
Trying to pip install your pull request like usual and this doesn't work:
Says it's not a tree. Any idea ? |
Try from the repo/branch the pull requests came from: |
To be more specific, use github's archive url: (tar.gz of branch temp-url)
.. or just clone the branch and run |
Using your fork works ... but I'm back to 401 ! |
When do you get 401? |
When I go to the generated url. |
Are you sure that added the |
Of course, look at my example, I'm even using it and... it works. |
ahh yes you are right. Fixing. |
Side comment : the unit tests should have spotted that it didn't work ;-) |
Yep they should ideally do that. Branch is updated 😄 Created issue #81 |
fixed |
Nope :
|
Must be a python 2 thing |
Fixed. all good things are 5? |
That was the one ! 👍 |
.. and I added unit test to verify the generated temp-url key. Please close this issue if there is nothing more to add. |
@Blacktorn @dperetti Can any one you close this issue? |
Obviously a quoting issue.
Suggestion : refactor url() using swiftclient's generate_temp_url().
FYI my quick and dirty workaround in my django app was as follow :
The text was updated successfully, but these errors were encountered: