Use swiftclient.utils.generate_temp_url #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 similar comments
dperetti
reviewed
Feb 9, 2017
swift/storage.py
Outdated
| @@ -360,7 +361,8 @@ def _path(self, name): | |||
| path = urlparse.urlsplit(url).path | |||
| msg = ('%s\n%s\n%s' % (method, expires, path)).encode() | |||
| sig = hmac.new(self.temp_url_key, msg, sha1).hexdigest() | |||
| url = url + '?temp_url_sig=%s&temp_url_expires=%s' % (sig, expires) | |||
| tmp_path = generate_temp_url(path, expires, sig, method, absolute=True) | |||
There was a problem hiding this comment.
I think we should not pass sig here, but self.temp_url_key, according to the docs.
dperetti
reviewed
Feb 9, 2017
swift/storage.py
Outdated
| @@ -357,11 +355,8 @@ def _path(self, name): | |||
| # Are we building a temporary url? | |||
| if self.use_temp_urls: | |||
| expires = int(time() + int(self.temp_url_duration)) | |||
| method = 'GET' | |||
| path = urlparse.urlsplit(url).path | |||
There was a problem hiding this comment.
Should be :
path = urlparse.unquote(urlparse.urlsplit(url).path)
..because name was quoted above (line 355).
3 similar comments
4 similar comments
|
@Blacktorn This one is more than ready now 😃 |
|
@Blacktorn Once again ready for merge. |
Roadmaster
added a commit
to Roadmaster/django-storage-swift
that referenced
this pull request
Jun 2, 2017
This reverts commit e2618ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for #79