Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #65

Merged
merged 12 commits into from
Nov 14, 2016
Merged

Tests #65

merged 12 commits into from
Nov 14, 2016

Conversation

einarf
Copy link
Contributor

@einarf einarf commented Nov 11, 2016

No description provided.

@einarf
Copy link
Contributor Author

einarf commented Nov 12, 2016

Coverage is about ~75%. A good start.

Feel free to merge.

@einarf einarf changed the title [WIP] Tests Tests Nov 12, 2016
@einarf
Copy link
Contributor Author

einarf commented Nov 13, 2016

80%. Think I'm done for now. Missing tests for name prefix etc, but I guess it's not realistic to get 100%.. at least not in first PR.

@einarf
Copy link
Contributor Author

einarf commented Nov 13, 2016

~84% coverage now. That's all I have the energy for now.

@einarf
Copy link
Contributor Author

einarf commented Nov 14, 2016

Found the courage to add a few more tests reaching 91% coverage.

@dennisv
Copy link
Owner

dennisv commented Nov 14, 2016

Wow, this is amazing work! 💯

@dennisv dennisv merged commit 7328e24 into dennisv:master Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants