Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce auth_version as string #68

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Conversation

einarf
Copy link
Contributor

@einarf einarf commented Nov 15, 2016

This should ensure backwards compatibility. This was changed in an earlier PR so this is a fix.

In general version numbers should be strings instead of numbers because you could end up having to represent a version number as a decimal. Example: 3.1 that could end up resolving into 3.09999999 in some cases.

Right now auth version is 1, 2 of 3 but that might not always be the case.

@dennisv dennisv merged commit fc15948 into dennisv:master Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants