Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region name parameter #78

Merged
merged 4 commits into from
Jan 20, 2017
Merged

Add region name parameter #78

merged 4 commits into from
Jan 20, 2017

Conversation

einarf
Copy link
Contributor

@einarf einarf commented Jan 19, 2017

Adds region name parameter.

Not tested, so don't merge yet! I think this is the only thing needed though.

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@einarf einarf closed this Jan 19, 2017
@einarf einarf reopened this Jan 19, 2017
@einarf
Copy link
Contributor Author

einarf commented Jan 19, 2017

Closed and reopened PR to trick travis into rebuilding. Something went wrong with init of a 2.7 env.

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@einarf
Copy link
Contributor Author

einarf commented Jan 19, 2017

I'll leave it here for a couple of hours. Travis is angry today.

@dennisv
Copy link
Owner

dennisv commented Jan 19, 2017

Might be caused by this commit in django master:
django/django@3cc5f01

@einarf einarf closed this Jan 19, 2017
@einarf einarf reopened this Jan 19, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

6 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 7545f13 on ZettaIO:region-name into 142c4ed on blacktorn:master.

@einarf
Copy link
Contributor Author

einarf commented Jan 19, 2017

@Blacktorn You are right. functools.lru_cache is python 3 only.

It seem that master is now Django 2.0 that dropped support for python 2.

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling fee6a5b on ZettaIO:region-name into 142c4ed on blacktorn:master.

@einarf
Copy link
Contributor Author

einarf commented Jan 19, 2017

@Blacktorn Yep. Just coffee overdose today :D

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 8121c8f on ZettaIO:region-name into 142c4ed on blacktorn:master.

@einarf einarf changed the title [WIP] Add region name parameter Add region name parameter Jan 19, 2017
@einarf
Copy link
Contributor Author

einarf commented Jan 19, 2017

Tested. Works!

EDIT: Note that that 3.4 was also removed because Django 2 has 3.5 as a minimum requirement. Then 3.6 will be minimum in 2.2 according to the roadmap.

@dennisv dennisv merged commit 8cdb863 into dennisv:master Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants