Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use swiftclient.Connection to handle operation retries natively #93

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

leo-naeka
Copy link
Contributor

This PR replaces regular swift methods by the swiftclient.Connection class that natively handles retries after any upload failure.

@codecov-io
Copy link

Codecov Report

Merging #93 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   97.84%   97.75%   -0.09%     
==========================================
  Files           1        1              
  Lines         232      223       -9     
==========================================
- Hits          227      218       -9     
  Misses          5        5
Impacted Files Coverage Δ
swift/storage.py 97.75% <100%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07084b8...a8125c2. Read the comment docs.

@einarf
Copy link
Contributor

einarf commented Nov 30, 2017

Nice one. I've been having this change in the back of my head for a long time. Also making sure the backend re-authenticates if the token expires.

@dennisv dennisv merged commit fe2e317 into dennisv:master Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants