Increase static storages specific settings support #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable use_temp_urls by default on static storages (should be public) Ensure that static container is created public if auto_create_container is True
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 97.84% 97.87% +0.02%
==========================================
Files 1 1
Lines 232 235 +3
==========================================
+ Hits 227 230 +3
Misses 5 5
Continue to review full report at Codecov.
|
|
I've reviewed those changes and I recommend merging them. Why does it take so long ?? |
|
thx ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
SWIFT_STATIC_AUTO_BASE_URLsettingDisable
use_temp_urlsby default on static storages (should be public)Ensure that static container is created public if
auto_create_container is TrueI took the decision to force
use_temp_urls=Truebecause I consider that statics must be publicly accessible on a large majority of deployments. In other cases, developers will have to override the storage class. Any thoughts on this?