Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase static storages specific settings support #95

Merged
merged 1 commit into from
May 29, 2019

Conversation

leo-naeka
Copy link
Contributor

Add the SWIFT_STATIC_AUTO_BASE_URL setting
Disable use_temp_urls by default on static storages (should be public)
Ensure that static container is created public if auto_create_container is True

I took the decision to force use_temp_urls=True because I consider that statics must be publicly accessible on a large majority of deployments. In other cases, developers will have to override the storage class. Any thoughts on this?

Disable use_temp_urls by default on static storages (should be public)
Ensure that static container is created public if auto_create_container is True
@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #95 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   97.84%   97.87%   +0.02%     
==========================================
  Files           1        1              
  Lines         232      235       +3     
==========================================
+ Hits          227      230       +3     
  Misses          5        5
Impacted Files Coverage Δ
swift/storage.py 97.87% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07084b8...944eb53. Read the comment docs.

@orzel
Copy link

orzel commented May 24, 2019

I've reviewed those changes and I recommend merging them. Why does it take so long ??

@dennisv dennisv merged commit 2d1fe19 into dennisv:master May 29, 2019
@orzel
Copy link

orzel commented Jun 13, 2019

thx ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants