-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gzip content #99
Gzip content #99
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 97.92% 98.03% +0.11%
==========================================
Files 1 1
Lines 241 255 +14
==========================================
+ Hits 236 250 +14
Misses 5 5
Continue to review full report at Codecov.
|
053b7a3
to
0b7a4e4
Compare
Make sure the table in readme has correct format. The entire table tends to disappear if that is not the case. That seems to be what one of the tests is angry about 😄 |
Oops, it's fixed ! |
tests/tests.py
Outdated
@@ -275,6 +275,16 @@ def test_save(self): | |||
dirs, files = self.backend.listdir('') | |||
self.assertEqual(files.count(name), 1) | |||
|
|||
@patch('tests.utils.FakeSwift.objects', new=deepcopy(CONTAINER_CONTENTS)) | |||
def test_save_gzip(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could mock/patch GzipFile for this test and check if it gets called instead.
Doesn't this test now just check if the file gets added and not if it gets gzipped?
I'm not proud of my test but I couldn't manage to find useful data to check the compression