Gzip content #99
Merged
Gzip content #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 97.92% 98.03% +0.11%
==========================================
Files 1 1
Lines 241 255 +14
==========================================
+ Hits 236 250 +14
Misses 5 5
Continue to review full report at Codecov.
|
Amoki
force-pushed
the
gzip-content
branch
3 times, most recently
from
053b7a3 to
0b7a4e4
Compare
|
Make sure the table in readme has correct format. The entire table tends to disappear if that is not the case. That seems to be what one of the tests is angry about 😄 |
|
Oops, it's fixed ! |
dennisv
reviewed
Mar 30, 2018
tests/tests.py
Outdated
| @@ -275,6 +275,16 @@ def test_save(self): | |||
| dirs, files = self.backend.listdir('') | |||
| self.assertEqual(files.count(name), 1) | |||
|
|
|||
| @patch('tests.utils.FakeSwift.objects', new=deepcopy(CONTAINER_CONTENTS)) | |||
| def test_save_gzip(self): | |||
There was a problem hiding this comment.
Maybe you could mock/patch GzipFile for this test and check if it gets called instead.
Doesn't this test now just check if the file gets added and not if it gets gzipped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not proud of my test but I couldn't manage to find useful data to check the compression