Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip content #99

Merged
merged 3 commits into from
Apr 12, 2018
Merged

Gzip content #99

merged 3 commits into from
Apr 12, 2018

Conversation

Amoki
Copy link
Contributor

@Amoki Amoki commented Mar 19, 2018

I'm not proud of my test but I couldn't manage to find useful data to check the compression

@codecov-io
Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #99 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   97.92%   98.03%   +0.11%     
==========================================
  Files           1        1              
  Lines         241      255      +14     
==========================================
+ Hits          236      250      +14     
  Misses          5        5
Impacted Files Coverage Δ
swift/storage.py 98.03% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3912a89...c334288. Read the comment docs.

@Amoki Amoki force-pushed the gzip-content branch 3 times, most recently from 053b7a3 to 0b7a4e4 Compare March 26, 2018 14:45
@einarf
Copy link
Contributor

einarf commented Mar 28, 2018

Make sure the table in readme has correct format. The entire table tends to disappear if that is not the case. That seems to be what one of the tests is angry about 😄

@Amoki
Copy link
Contributor Author

Amoki commented Mar 29, 2018

Oops, it's fixed !

tests/tests.py Outdated
@@ -275,6 +275,16 @@ def test_save(self):
dirs, files = self.backend.listdir('')
self.assertEqual(files.count(name), 1)

@patch('tests.utils.FakeSwift.objects', new=deepcopy(CONTAINER_CONTENTS))
def test_save_gzip(self):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could mock/patch GzipFile for this test and check if it gets called instead.
Doesn't this test now just check if the file gets added and not if it gets gzipped?

@dennisv dennisv merged commit d7c0e8a into dennisv:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants