fix: FastString v8_string() should error when cannot allocated #27375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
littledivy
changed the title
bartlomieju
reviewed
Dec 16, 2024
ext/fs/ops.rs
Outdated
| @@ -1424,6 +1424,7 @@ impl<'s> ToV8<'s> for V8MaybeStaticStr { | |||
| Cow::Owned(value) => value.into(), | |||
| } | |||
| .v8_string(scope) | |||
| .unwrap() | |||
There was a problem hiding this comment.
You probably want to return error here instead of crashing
bartlomieju
approved these changes
Dec 16, 2024
dsherret
pushed a commit
that referenced
this pull request
Jan 9, 2025
Upgrades deno_core to 0.326.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades deno_core to 0.326.0