Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): fix formatting of debug logs #27772

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 22, 2025

Currently %s placeholders in debug logs in node compat js code are not handled correctly. This PR fixes it.

BEFORE
Screenshot 2025-01-22 at 16 18 33

AFTER
Screenshot 2025-01-22 at 16 24 58

@kt3k kt3k merged commit 773825a into denoland:main Jan 22, 2025
17 checks passed
@kt3k kt3k deleted the fix-debug-logger-in-node-compat-layer branch January 22, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants