-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(lsp): add built-in tracing support for the LSP #27843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62347e3
to
b83c056
Compare
bartlomieju
commented
Jan 31, 2025
bartlomieju
commented
Jan 31, 2025
bartlomieju
commented
Jan 31, 2025
b83c056
to
afe53d4
Compare
ecec89d
to
0cd4eec
Compare
bartlomieju
commented
Feb 12, 2025
@@ -1331,6 +1386,8 @@ impl Inner { | |||
self.config.set_workspace_settings(settings, vec![]); | |||
} | |||
}; | |||
// TODO(nathanwhit): allow updating after startup, needs work to set thread local collector on tsc thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to actually address this? If not, then open an issue so it doesn't get lost
779bad8
to
5ec5915
Compare
5ec5915
to
d80df75
Compare
nathanwhit
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds tracing and opentelemetry exporting to the LSP.
enable it in
.vscode/settings.json
(or wherever you configure the LSP), likewhich will by default export opentelemetry traces to
localhost:4317
or
a full working setup would be
1: Run jaeger (an opentelemetry collector with a nice UI):
http://localhost:16686
in your browser