fix(cli): Fix panic in load_native_certs
#27863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jan 29, 2025
| @@ -89,7 +91,9 @@ pub fn get_root_cert_store( | |||
| root_cert_store.extend(webpki_roots::TLS_SERVER_ROOTS.to_vec()); | |||
| } | |||
| "system" => { | |||
| let roots = load_native_certs().expect("could not load platform certs"); | |||
| let roots = load_native_certs().map_err(|err| { | |||
| RootCertStoreLoadError::FailedNativeCerts(err.to_string()) | |||
There was a problem hiding this comment.
Maybe change to:
FailedNativeCerts {
#[source]
source: ...
}
There was a problem hiding this comment.
Cannot store std::io::Error because RootCertStoreLoadError needs to implement Clone
bartlomieju
approved these changes
Jan 31, 2025
bartlomieju
pushed a commit
that referenced
this pull request
Feb 12, 2025
Fixes #27528 Can't really trigger the panic myself hence no test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27528
Can't really trigger the panic myself hence no test.