Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better jsx workspace config resolution #28186

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix: better jsx workspace config resolution #28186

merged 2 commits into from
Feb 19, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret marked this pull request as ready for review February 19, 2025 22:41
@dsherret dsherret requested a review from bartlomieju February 19, 2025 22:41
dsherret
dsherret commented Feb 19, 2025
View reviewed changes
cli/lsp/resolver.rs
@@ -997,7 +997,7 @@ impl<'a> deno_graph::source::Resolver for SingleReferrerGraphResolver<'a> {
) -> Option<String> {
self
.jsx_import_source_config
.and_then(|c| c.default_specifier.clone())
.and_then(|c| c.import_source.as_ref().map(|s| s.specifier.clone()))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of feel like we should be providing the base to deno_graph, but I guess people don't use jsxImportSource with relative urls.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I don't think other transpilers support relative paths and just mindlessly insert the given string value. Would be kinda cool for prototyping if relative-style import source would be supported though.

@dsherret dsherret mentioned this pull request Feb 19, 2025
Merged
@dsherret dsherret merged commit 3da3fe8 into denoland:main Feb 19, 2025
18 of 22 checks passed
@dsherret dsherret deleted the fix_better_jsx_resolution branch February 19, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @marvinhagemeister @lucacasonato