Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lsp): don't set resolver npm reqs if unchanged #28302

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Feb 25, 2025

Towards #28300. The slowness will still occur on init and config changes, but not on every edit.

@nathanwhit
Copy link
Member

(note: the lint CI job failing is unrelated to this, will be fixed by #28301)

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants