Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): require esm should prefer module.exports export #28376

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix(node): require esm should prefer module.exports export #28376

merged 1 commit into from
Mar 3, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 3, 2025

@dsherret dsherret changed the title fix(node): require esm should prefer module.exports export fix(node): require esm should prefer module.exports export Mar 3, 2025
nathanwhit
nathanwhit approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit bf06042 into denoland:main Mar 3, 2025
18 checks passed
@dsherret dsherret deleted the fix_require_esm_module_exports_exports branch March 3, 2025 20:03
littledivy pushed a commit that referenced this pull request Mar 5, 2025
@dsherret @littledivy
fix(node): require esm should prefer module.exports export (#28376)
08b0b72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@nayeemrmn nayeemrmn nayeemrmn approved these changes

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export { n as "module.exports" } not supported for require(esm)
3 participants
@dsherret @nathanwhit @nayeemrmn