Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.18.0 #600

Merged
merged 4 commits into from
Sep 18, 2019
Merged

v0.18.0 #600

merged 4 commits into from
Sep 18, 2019

Conversation

ry
Copy link
Member

@ry ry commented Sep 16, 2019 •
edited
Loading

No description provided.

@ry ry requested a review from piscisaureus September 16, 2019 18:19
@ry ry force-pushed the bump branch 2 times, most recently from 6a724f1 to c6c2bca Compare September 18, 2019 15:44
@ry
Copy link
Member Author

ry commented Sep 18, 2019

I had to remove two tests to get this to pass. I will start an issue to bring them back once this is landed.

piscisaureus
piscisaureus approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do these tests randomly break?

@ry
Copy link
Member Author

ry commented Sep 18, 2019

I don't know why they broke - but this is a major reason why I will merge deno_std into the main repo.

@ry ry merged commit a8f6cf7 into denoland:master Sep 18, 2019
ry added a commit to ry/deno that referenced this pull request Oct 9, 2019
@ry
v0.18.0 (denoland/std#600)
3e9c791 
Several tests were disabled in order to land this update.
Original: denoland/std@a8f6cf7
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@iuioiua
fix: account page spacing (denoland#600)
4dadb5b 
Before:
![hunt deno
land_account](https://github.com/denoland/saaskit/assets/29347852/595dd087-d05d-453d-b676-ca8febaee4b0)

After:

![localhost_8000_account](https://github.com/denoland/saaskit/assets/29347852/12e749a4-bc58-4eaf-a139-f66b4c34dede)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @piscisaureus