-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import enhancement #172
Import enhancement #172
Conversation
update from upstream
This comment has been minimized.
This comment has been minimized.
6614e1c
to
9e52604
Compare
9e52604
to
d89fa0e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There are no docs. Also there is no option for alphabetical sort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out locally and it is working great so far. Very awesome feature @CGQAQ!
Don't have internet right now, the typhoon is coming. I'll change it as soon as the internet back |
Co-authored-by: Luca Casonato <[email protected]>
…o import_enhancement
* version completion now works anywhere between @ and /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other minor comments:
- Autocomplete only works correctly if
@
and/
for path are present. Example:
import { } from "https://deno.land/x/sq" // intellisense does not complete this to sqs
import { } from "https://deno.land/x/" // intellisense does work for one round now
import { } from "https://deno.land/x/sqs@" // intellisense does not suggest versions now
import { } from "https://deno.land/x/sqs@/" // intellisense does suggest versions now between @ and /
-
Not specifying a version means path completion doesn't work (I am actually ok with this, maybe people will stop using it then 😄)
-
Typing some characters of the module name does not retrigger search. You have to manually retrigger with
Esc
thenCtrl + Space
- it would be great if typing a char would trigger the search at the server to happen again. (This is fine for the first pass, but if you know how to solve it that would be awesome).
@lucacasonato I have completely rewrite the completion logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! This is a really awesome feature to have :-)
Thank you for helping me to have this done, also great thanks to @jrieken from Microsoft for helping me out |
I'll read the server code later and see what I can do. (话说你有qq开发群吗?这里讨论不是很方便) |
以前有,现在没有精力去搞这种了,Github 就是很好的交流社区 |
可惜没有私聊,评论太多不好,感觉性能提升不了多少,毕竟有http请求,不过体验应该会更好,而cache过的在client端的实现也看不出延迟 |
and BTW. There is already a cache module and it has been well tested. See Lines 3 to 15 in 65a0928
|
Ok, I'll remove |
)" This reverts commit dd25cff. Don't need these now, will move to server
@axetroy but how to permanent the cache to disk |
@CGQAQ This is only a memory cache. If you need to cache to the disk, you can implement it yourself or use a third-party library |
which folder should I put? do you have any suggestions? I will put it in vscode_deno/cache at the same location of deno folder |
REWRITE OF #115 DUE TO REPO BASE REPLACEMENT
update cache by tracking the uploaded_at from this APIShowcase:
Completely redesign completion
Before
After
closes #114