-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable disable command #197
Conversation
update from upstream
update from upstream
update from upstream
Update from upstream
@bartlomieju @axetroy @lucacasonato Ready for review |
I remember this addition was debated before in the old extension and removed. I like the idea, but my only reservation is that now there are more options, logically they should be togglable as well? Perhaps instead
This could be a nice time-saver? It would force people to make decisions on these options right away, and educate them that they exist. |
I think to add every config to command is not a good idea |
as I said. #170 (comment) Consider adding a |
Don't need anymore |
Depends on #196, Please review it first
Show
enable command
when lsp is disabled,disable command
when lsp is enabledPart of roadmap 2 (#194)
Closes #170