Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-IIR 1426] create entry for new version of VR&E form #2460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

john-rodriguez-adhocteam
Copy link
Contributor

@john-rodriguez-adhocteam john-rodriguez-adhocteam commented Feb 25, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing or changing a registry.json entryName in this PR?

  • No, I'm not changing any entryNames (skip to Summary and delete the rest of this section)
  • Yes, I'm removing or changing an entryName

If you are:

  1. Deleting an entryName: First search vets-website for references to this entryName that are not in the app folder (particularly in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js) and merge a PR that removes those references, if any.

    • Add the link to your merged vets-website PR here
  2. Changing an entryName: First search vets-website for references to this entryName that are not in the app folder (particularly in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js) and merge a PR that updates those references, if any.

    • Add the link to your merged vets-website PR here

If you do not do this, other applications will break!

Summary

  • This is work for the VA-IIR team.
  • We are temporarily assisting the Benefits team with the VR&E form over the next few months.
  • The form needs to be updated to match the latest paper form and web component versions. We were encouraged to create a newly constructed form.
  • This PR creates the initial set up of the registry for the new form app.
  • The new form app will not be released to prod yet. vagovprod is set to false.
  • The new form app will live at a temporary URL until a finalized URL is provided and then it will be updated.

Related issue(s)

What areas of the site does it impact?

None other beyond this new form app.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/vre/new-28-1900/1426-new-vre-281900-setup/vre/new-28-1900/1426-new-vre-281900-setup February 25, 2025 22:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/vre/new-28-1900/1426-new-vre-281900-setup/vre/new-28-1900/1426-new-vre-281900-setup February 26, 2025 16:21 Inactive
@john-rodriguez-adhocteam john-rodriguez-adhocteam marked this pull request as ready for review February 26, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants