Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's confusing when to use go_modules vs gomod #6577

Open
1 task done
jeffwidman opened this issue Feb 2, 2023 · 2 comments
Open
1 task done

It's confusing when to use go_modules vs gomod #6577

jeffwidman opened this issue Feb 2, 2023 · 2 comments

Comments

@jeffwidman
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Code improvement description

gomod is a leftover from when go didn't have a cannonical package manager, so there was the go dep project and several others.

We've also now got go_modules and it's confusing which to use where... for example:

We should standardize on a cannonical name for go modules. We could use go, since I doubt there will be another package manager in that ecosystem, but that also feels risky in case I'm wrong... so go_modules is probably the safest solution.

So this is a reminder to me to investigate what it'd take to standardize on that.

@markdorison
Copy link
Contributor

This is not just true for Go, but also for a number of other ecosystems. The example below from one of this repo's workflows shows the following items differ:

NAME ECOSYSTEM
git_submodules gitsubmodule
github_actions github-actions
go_modules gomod
hex mix
npm_and_yarn npm
python pip

suite:
- { name: bundler, ecosystem: bundler }
- { name: cargo, ecosystem: cargo }
- { name: composer, ecosystem: composer }
- { name: docker, ecosystem: docker }
- { name: elm, ecosystem: elm }
- { name: git_submodules, ecosystem: gitsubmodule }
- { name: github_actions, ecosystem: github-actions }
- { name: go_modules, ecosystem: gomod }
- { name: gradle, ecosystem: gradle }
- { name: hex, ecosystem: mix }
- { name: maven, ecosystem: maven }
- { name: npm_and_yarn, ecosystem: npm }
- { name: nuget, ecosystem: nuget }
- { name: pub, ecosystem: pub }
- { name: python, ecosystem: pip }
- { name: terraform, ecosystem: terraform }

Should this issue cover all of these?

@krokofant
Copy link

krokofant commented May 31, 2023

@markdorison This was especially confusing when wanting to maintain the ecosystem-label when there is only one ecosystem then dependabot only adds the "dependency" label, but for easier search I'd like to have the ecosystem-label everywhere. It was a bit hard to find which label is actually added.

Via this issue I know that I should add the label "github_actions" instead of the ecosystem name "github-actions".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants