Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to link to list of package managers. #6575

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

markdorison
Copy link
Contributor

When I was working with the Docker image locally, it took me a minute to parse what the acceptable arguments were for the package manager. I added a link to the documentation, but I am not sure that is the best place, as I see gomod listed there for Go as opposed to go_modules used here. I see the list with names in some of the GitHub actions workflows.

Is there a better, more canonical place that I could link this documentation to with the appropriate values?

@markdorison markdorison requested a review from a team as a code owner February 2, 2023 18:29
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark, and I feel your pain, I hit the same thing yesterday.

Unfortunately, the naming is a bit confusing here because it's actually the ruby module name in this context... ie, go_modules rather than gomod.

This is a horrid user experience, and probably one we should cleanup sooner rather than later.

If it's okay with you, let's float this PR for a bit as a reminder to me to look into what it'd take to start to standardize some of this to reduce confusion... I don't think saying "go_modules" one place and "gomod" is intuitive for anyone.

@markdorison
Copy link
Contributor Author

@jeffwidman That makes sense to me. There is probably more elegant way to solve this in the long run, but in the meantime, should we turn this into a table for the README similar to what I did in #6577 (comment)?

Copy link
Contributor

github-actions bot commented Feb 2, 2025

👋 This pull request has been marked as stale because it has been open for 2 years with no activity. You can comment on the PR to hold stalebot off for a while, or do nothing. If you do nothing, this pull request will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot added the Stale label Feb 2, 2025
@robaiken robaiken enabled auto-merge (squash) February 13, 2025 16:54
@robaiken robaiken merged commit e31b256 into dependabot:main Feb 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants