-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bumping uses: docker://…
in GitHub Actions workflows
#8362
Labels
T: feature-request
Requests for new features
Comments
3 tasks
l0b0
added a commit
to linz/topo-workflows
that referenced
this issue
Nov 8, 2023
Works around <dependabot/dependabot-core#8362> for now.
l0b0
added a commit
to linz/topo-workflows
that referenced
this issue
Nov 8, 2023
Works around <dependabot/dependabot-core#8362> for now.
l0b0
added a commit
to linz/topo-workflows
that referenced
this issue
Nov 8, 2023
Works around <dependabot/dependabot-core#8362> for now.
l0b0
added a commit
to linz/topo-workflows
that referenced
this issue
Nov 8, 2023
Works around <dependabot/dependabot-core#8362> for now.
l0b0
added a commit
to linz/topo-workflows
that referenced
this issue
Nov 9, 2023
Works around <dependabot/dependabot-core#8362> for now.
l0b0
added a commit
to linz/topo-workflows
that referenced
this issue
Nov 9, 2023
Works around <dependabot/dependabot-core#8362> for now.
l0b0
added a commit
to linz/topo-workflows
that referenced
this issue
Nov 14, 2023
Works around <dependabot/dependabot-core#8362> for now.
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this issue
Nov 14, 2023
#### Motivation https://toitutewhenua.atlassian.net/browse/TDE-919 #### Modification Lint GitHub Actions workflow files. Works around <dependabot/dependabot-core#8362> for now. #### Checklist - [ ] Tests updated (this is not testable) - [ ] Docs updated (does not need documentation) - [x] Issue linked in Title
+1 for adding support for this. All the LEGO pieces to do it exist in the repo, they're just spread across the Actions and Docker updaters and don't overlap. Until this is a native feature, I've written a GitHub Actions workflow that does this on a schedule using the same regclient tool that the Docker updater uses. |
That would be a great feature indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Feature description
To reproduce
Create a new Git repo
Create
.github/workflows/main.yml
containingCreate
.github/dependabot.yml
containingPush to GitHub
Run Dependabot
What happens: No PRs are created
What should happen: Dependabot should create a PR changing
uses: docker://rhysd/actionlint:1.6.25@sha256:86ebdb1c0df5a8be92b9d53e2e0c636978a2b3c6e52c86c65a77e2c78a6bd594
touses: docker://rhysd/actionlint:1.6.26@sha256:2eb91a78b5a19140be099c7b4262d298c2567f2a9f27e10ed2a4323c5bcface8
.Other info
This seems to be a known problem based on this 4-year-old comment, but I couldn't find an associated issue.
Workaround
.github/workflows/actionlint.dockerfile
, with just aFROM …
line containing everything afteruses: docker://
from the original workflow. For the example above,FROM rhysd/actionlint:1.6.25@sha256:86ebdb1c0df5a8be92b9d53e2e0c636978a2b3c6e52c86c65a77e2c78a6bd594
.run: docker build --tag actionlint - < .github/workflows/actionlint.dockerfile
run: docker run --volume="${PWD}:/repo" --workdir=/repo actionlint
.package-ecosystem: "docker"
withdirectory: "/.github/workflows"
.FROM rhysd/actionlint:1.6.26@sha256:2362769b1d75056da70e7af1b12d9e52746f3a123b8f22a4322869e8f2cd45f2
The text was updated successfully, but these errors were encountered: