don't continue checking a non-existant feed for a package #11252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
previously approved these changes
Feb 5, 2025
JamieMagee
force-pushed
the
dev/brettfo/nuget-source-no-such-host
branch
from
aedecb4 to
3f94c62
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-source-no-such-host
branch
from
3f94c62 to
6d2735c
Compare
JamieMagee
approved these changes
Feb 24, 2025
randhircs
force-pushed
the
dev/brettfo/nuget-source-no-such-host
branch
from
6d2735c to
6a1ea91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found when scanning internal logs.
If a feed is specified with an internal-only URL, checking that feed for possible updates will obviously fail. We don't want to fail the entire update process, though, because it's entirely possible for a repo to list both public and internal feeds and to only want dependabot to run for public packages.
The fix is to broaden the scope of the
tryblock so that if fetching the service index fails, we simply continue onto the next source.