-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for docker-compose.yml files #11492
Conversation
fba0088
to
72940c0
Compare
@robaiken I am so happy to see this being addressed! I noticed you focus on docker-compose.yml (sometimes spelled docker-compose.yaml), since some time compose.yaml is the preferred file name https://docs.docker.com/compose/intro/compose-application-model/, could you please make sure to include all 4 varriations?
|
Good point. In some project you'll even find things like Of course, using Compose Profiles could solve the need for multiple compose files, but projects providing a compose file for self-hosting maybe don't want to include everything dev related by default. @robaiken |
55db598
to
d86cce5
Compare
Hi @Aaron-Ritter and @swissbuechi 👋 The file fetcher for Docker Compose already handles all the standard naming variations you mentioned:
@swissbuechi I've updated the regex to also support environment-specific compose files with hyphenated patterns (like compose-dev.yaml). Thanks for the suggestion.
we currently have limited support for this. Feel free to submit a feature request if you'd like to see expanded configuration options for compose file patterns. |
One more question @robaiken, am i understanding it correctly that you add docker_compose as a own Package Manager rather than extending docker? Why i am asking is because the docker package manager at the moment takes care of both Dockerfile as well as kubernetes yaml configurations. |
8ccf6f9
to
cfd6487
Compare
@Aaron-Ritter We're intentionally keeping docker compose separate from the docker image manager to avoid the complexity that comes from combining ecosystems. While combining them might seem convenient, it often leads to "magic" behavior that's hard to debug. Separate ecosystems = clearer boundaries and more predictable behavior. |
What are you trying to accomplish?
Adding support for
docker-compose.yml
files in the docker package ofdependabot-core
. This will allow Dependabot to handle dependency updates in Docker Compose files alongside regular Dockerfile updates.This addresses issue #390
Big thanks to @pedropombeiro for the initial implementation of this feature and @oceanBT for keeping the PR alive
How will you know you've accomplished your goal?
Dependabot successfully detects and updates dependencies in
docker-compose.yml
files automatically.Checklist