Drop Python 3.8 support #11529
Merged
Drop Python 3.8 support #11529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggplants
force-pushed
the
drop-python-3.8
branch
from
a3aabee to
be6ac47
Compare
Dropping `3.8` as announced here: https://github.blog/changelog/2025-02-05-dependabot-no-longer-supports-python-3-8/
amazimbe
force-pushed
the
drop-python-3.8
branch
from
be6ac47 to
fa9263e
Compare
amazimbe
approved these changes
Feb 14, 2025
m-roberts
reviewed
Feb 14, 2025
| # TODO: Drop the conditions and use the latest version once we drop support for Python 3.8. | ||
| hashin==1.0.2; python_version < '3.9' | ||
| hashin==1.0.3; python_version >= '3.9' |
There was a problem hiding this comment.
suggestion: Drop python_version condition altogether, now that latest version can be used (according to TODO).
There was a problem hiding this comment.
Thank you, I've created #11601
This was referenced Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Dropping
3.8as announced here:https://github.blog/changelog/2025-02-05-dependabot-no-longer-supports-python-3-8/
Previous same changes:
python3.6#7610Anything you want to highlight for special attention from reviewers?
Workflows is passed in my repo action, except one smoke test related to pipenv:
https://github.com/eggplants/dependabot-core/actions/runs/13204029589
Maybe need updating https://github.com/dependabot/smoke-tests/tree/main/pipenv or others to drop 3.8.
→ dependabot/smoke-tests#257
How will you know you've accomplished your goal?
#11275's test has passed after rebasing/merging its branch.
Checklist